09-02-2011, 03:58 AM
I'm confused on what the issue is.
Is their code sloppy?
Is the UX/UI they're creating bad?
I recently had someone review my code. They asked for code that was exceptionally pretty. I told them up-front that my code wasn't perfectly formatted everywhere like a work of art (that's what they were requesting.) I explained this was because generally the budget for the project was better spent elsewhere.
That sort of stuff takes time. The end result to the client is that I spent their money making sure everything was indented properly, no extra lines, all comments were consistent... rather than making a difference in many other ways that would actually have an impact on the bottom line.
Pam (and I'm not picking on her) said that "There's no right or wrong here." and I don't think we've been given enough information to determine that. If their work is:
1. Causing more work for their coworkers
2. Creating problems they'll have to deal with down the road
3. Creating a bad user experience
4. Hurting the company's bottom line...
Then what they're doing is clearly wrong. I know people who write the sloppiest CSS and then just use Firebug to sift their way through the mess they created, constantly overriding styles... and that wastes their own time as well as anyone else who has to work on it. That IS wrong.
You have to find out if what they do causes a negative impact like those mentioned above. Then you have to find a way to convey that to them so they are motivated to solve the problem - for their own reasons - not yours. And if they, for example, don't care if it hurts the company's bottom line then you need to take it up with the chain of command. If it doesn't actually cause a problem other than it doesn't match your own personal definition of excellence, put your energy elsewhere.
Is their code sloppy?
Is the UX/UI they're creating bad?
I recently had someone review my code. They asked for code that was exceptionally pretty. I told them up-front that my code wasn't perfectly formatted everywhere like a work of art (that's what they were requesting.) I explained this was because generally the budget for the project was better spent elsewhere.
That sort of stuff takes time. The end result to the client is that I spent their money making sure everything was indented properly, no extra lines, all comments were consistent... rather than making a difference in many other ways that would actually have an impact on the bottom line.
Pam (and I'm not picking on her) said that "There's no right or wrong here." and I don't think we've been given enough information to determine that. If their work is:
1. Causing more work for their coworkers
2. Creating problems they'll have to deal with down the road
3. Creating a bad user experience
4. Hurting the company's bottom line...
Then what they're doing is clearly wrong. I know people who write the sloppiest CSS and then just use Firebug to sift their way through the mess they created, constantly overriding styles... and that wastes their own time as well as anyone else who has to work on it. That IS wrong.
You have to find out if what they do causes a negative impact like those mentioned above. Then you have to find a way to convey that to them so they are motivated to solve the problem - for their own reasons - not yours. And if they, for example, don't care if it hurts the company's bottom line then you need to take it up with the chain of command. If it doesn't actually cause a problem other than it doesn't match your own personal definition of excellence, put your energy elsewhere.